New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not Change Quotation Style for PT006
Autofix
#1600
Conversation
); | ||
|
||
if let Ok(content) = generator.generate() { | ||
check.amend(Fix::replacement( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tweak these to log the error on failure? If you grep for similar generate calls, you should be able to find the preferred pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks for the quick review. Really enjoying learning Rust. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.209` -> `^0.0.210` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.210/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.210/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.210/compatibility-slim/0.0.209)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.210/confidence-slim/0.0.209)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.210`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.210) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.209...v0.0.210) #### What's Changed - Do not Change Quotation Style for `PT006` Autofix by [@​saadmk11](https://togithub.com/saadmk11) in [astral-sh/ruff#1600 - Implement autofix for `PT022` by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#1604 - Add isort.order-by-type boolean setting by [@​mattoberle](https://togithub.com/mattoberle) in [astral-sh/ruff#1607 - Fix \*arg and \*\*kwarg handling for Google docstrings by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1608 - Associate inline comments with parenthesized `ImportFrom` statements by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1609 - Fix leftover whitespace when removing `pass` for `PIE790` by [@​edgarrmondragon](https://togithub.com/edgarrmondragon) in [astral-sh/ruff#1612 - Treat .pyi files as **future** annotations-enabled by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1616 - Treat convention as setting ignore, rather than select by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1611 - Avoid byte-string conversions by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1618 - Implement missing fixes for `PT006` by [@​edgarrmondragon](https://togithub.com/edgarrmondragon) in [astral-sh/ruff#1622 - Implement `yield`-to-`yield from` conversion by [@​colin99d](https://togithub.com/colin99d) in [astral-sh/ruff#1544 - Add some more users to the README by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1623 - Check `SIM118` in comprehension by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#1627 #### New Contributors - [@​mattoberle](https://togithub.com/mattoberle) made their first contribution in [astral-sh/ruff#1607 **Full Changelog**: astral-sh/ruff@v0.0.209...v0.0.210 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44MS4wIiwidXBkYXRlZEluVmVyIjoiMzQuODEuMCJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
closes #1592