Add autofix for W292 [NoNewLineAtEndOfFile] #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: `.swp` is a temporary file type used by vim
|
Thanks for this -- looks great! No idea what happened with the multiple authors, that's extremely strange, but kind of funny :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an autofix for W292, updated the tests, and updated the README. I'm relatively new to Rust and would love any feedback (even though there isn't many changes). If you would prefer, I could move the check into
plugins.rsinstead of keeping it in the same file. Also, if you want, I can open an issue as specified inCONTRIBUTING.mdif this is considered bigger changes.Unrelated note: I ran
git pushon my own machine with my own PAT (personal access token) and somehow on the first commit someone named "@kasryan" committed, but on later commits with the same command and PAT I was correctly shown as the person who committed. I have no clue who @kasryan is.