forked from percy/percy-style
-
Notifications
You must be signed in to change notification settings - Fork 0
/
private_attribute_accessors_spec.rb
90 lines (76 loc) · 2.69 KB
/
private_attribute_accessors_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
require 'spec_helper'
require 'rubocop'
require './lib/private_attribute_accessors'
describe RuboCop::Cop::Style::PrivateAttributeAccessors do
subject(:cop) { described_class.new }
# These helper methods are from https://github.com/bbatsov/rubocop/blob/4b26354497f32da8d771f35c66b2f47224f9674b/spec/support/cop_helper.rb#L10
def inspect_source(cop, source, file = nil)
if source.is_a?(Array) && source.size == 1
fail "Don't use an array for a single line of code: #{source}"
end
RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
processed_source = parse_source(source, file)
fail 'Error parsing example code' unless processed_source.valid_syntax?
_investigate(cop, processed_source)
end
def parse_source(source, file = nil)
source = source.join($RS) if source.is_a?(Array)
if file && file.respond_to?(:write)
file.write(source)
file.rewind
file = file.path
end
RuboCop::ProcessedSource.new(source, 2.6, file)
end
def _investigate(cop, processed_source)
forces = RuboCop::Cop::Force.all.each_with_object([]) do |klass, instances|
next unless cop.join_force?(klass)
instances << klass.new([cop])
end
commissioner =
RuboCop::Cop::Commissioner.new([cop], forces, raise_error: true)
commissioner.investigate(processed_source)
commissioner
end
it 'registers an offense for using any attr_* methods in private scope' do
inspect_source cop, <<-RUBY.strip_indent
class SmallThing < Thing
private
attr_reader :anything
attr_writer :something
attr_accessor :nothing
end
RUBY
expect(cop.offenses.size).to eq(3)
expect(cop.offenses.map(&:message))
.to eq(['Do not use private attribute accessors',
'Do not use private attribute accessors',
'Do not use private attribute accessors'])
end
it 'can handle non-access modifier node types' do
inspect_source cop, <<-RUBY.strip_indent
class AwesomeController < RighteousController
def create
case variable_name
when 'something'
OtherClass::WorkerClass.perform_async argument
when 'something else'
OtherClass::WorkerClass.perform_async argument
end
head :ok
end
end
RUBY
expect(cop.offenses.size).to eq(0)
end
it 'isn\'t offend by using any attr_* methods in public scope' do
inspect_source cop, <<-RUBY.strip_indent
class SmallThing < Thing
attr_reader :anything
attr_writer :something
attr_accessor :nothing
end
RUBY
expect(cop.offenses.size).to eq(0)
end
end