Distinguish between final and intermediate ResultDict #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not enough of a mypy user to understand the point of this one. Why do we care about then difference between these two? |
The IntermediateResultDict has optional fields where as the final, all fields can't be None. Carried over from the typeshed types: https://github.com/python/typeshed/blob/ee09a67c5cf61effaae1bdb894571eac4fc9ac6b/stubs/chardet/chardet/__init__.pyi
|
This is something @hauntsaninja suggested in the typeshed thread: python/typeshed#8182 It was carried over from the typeshed implementation. I'm not 100% sure on its utility and if it can't be justified as useful, I'm fine to see this closed without merge. |
|
Thanks for the PR and the review! The idea here is that the following should pass type check: Without this PR, type checkers would complain because it looks like there's the possibility of trying to do |
dan-blanchard
added a commit
that referenced
this pull request
Dec 1, 2022
This reverts commit 023e7ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IntermediateResultDict has optional fields where as the final, all
fields can't be None.
Carried over from the typeshed types:
https://github.com/python/typeshed/blob/ee09a67c5cf61effaae1bdb894571eac4fc9ac6b/stubs/chardet/chardet/__init__.pyi