Add should_rename_legacy flag to allow WHATWG-inspired renaming #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2022
Closed
dan-blanchard
changed the title
|
After further reading about different encodings, it becomes clear that annoyingly the WHATWG group's names for some encodings to do not match the Python names, so I'm going to tweak this to more directly map what everyone has been asking for 😅 |
dan-blanchard
force-pushed
the
feature/legacy_mode
branch
from
f29184c
to
1116b1d
Compare
dan-blanchard
force-pushed
the
feature/legacy_mode
branch
from
1116b1d
to
d511e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
should_rename_legacyflag, so that people can opt into renaming legacy encodings according to the W3C offshoot WHATWG group's suggested mapping here. This should address long-standing complaint about us returninggb2312instead of at leastgbk, and things like that. One interesting side effect of this change is that they suggest mapping ASCII and ISO-8859-1 to Windows-1252, so we will return Windows-1252 a lot more often with this flag on.