Remove shebang from nonexecutable script #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packaging chardet and pip (which bundles it) in Fedora, we have realized
that there is a nonexecuatble file with a shebang line.
It seems that the primary purpose of this file is to be imported from Python
code or to be executed via
python chardet/cli/chardetect.py
orpython -m chardet.cli.chardetect
and hence the shebang appears to be unnecessary.Shebangs are hard to handle when doing downstream packaging, because it makes
sense for upstream to use
#!/usr/bin/env python
while in the RPM package, weneed to avoid that and use a more specific interpreter. Since the shebang was
unused, I propose to remove it to avoid the problems.