Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging should be given a NullHandler #177

Open
sterns1 opened this issue Jun 20, 2019 · 1 comment
Open

logging should be given a NullHandler #177

sterns1 opened this issue Jun 20, 2019 · 1 comment

Comments

@sterns1
Copy link

sterns1 commented Jun 20, 2019

Hi,

I am getting DEBUG logging statements from this library by way of the requests library. To keep chardet logging messages from showing up in my logging output, I have to explicitly setLevel(logging.WARNING) for the chardet logger.

Would it be reasonable to add a NullHandler to your logger with the level of Logging.INFO? WARNING should still be displayed as described at https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library . Or is this not a problem, and the responsibility to silence all imported modules' logging on the person importing the library?

@michelcrypt4d4mus
Copy link

+1 it should be both possible and easy for users to specifiy the verbosity of logging that they want to see when using the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants