Add Chapel support to Google prettify

[bradcray]

As I understand it from StackOverflow's markdown help page, if we were to add Chapel support to Google's prettify, we'd get syntax highlighting for code on StackOverflow which seems very attractive.

TODO:

• verify that the above is true
• create and submit Chapel support to prettify

[ronawho]

Related to #5908

[victor-ludorum]

@bradcray Hello!! I want to work on this issue . Kindly guide me ..

[bradcray]

Hi @victor-ludorum : I'd be very happy to see this done, but I don't know enough about Google prettify to be able to provide very deep guidance beyond some simple pointers. However, they look like they have pretty good documentation about how to add new languages in their README, and a common approach is to find an existing language that is sufficiently similar to Chapel and follow its example. That's how I'd start into this anyway. It may also be useful to look at other tools that support Chapel highlighting, several of which are noted in issue #5908.

[victor-ludorum]

Thanks sir for your suggestion 😊 .

[bradcray]

Hi @victor-ludorum : Thanks for your PR for this. I'm not sure what it will take for it to be merged to Google prettify—they seem to have quite a backlog. Have you come across any documentation indicating steps that should be taken to get PRs to their repository reviewed and merged?

[victor-ludorum]

@bradcray Yes sir , I have signed Google Contributor License Agreement (CLA) as mentioned there .

[ghost]

@victor-ludorum Hey friend, I think you have missed the keyword 'sync'. I've reviewed that in your PR.

[victor-ludorum]

Thanks @aditmehta9 for specifying . I have added it 😊

[krishnadey30]

@bradcray I checked the google prettify github. They also say prettify is used by Stackoverflow.

• verify that above is true

I would like to take this issue.

[krishnadey30]

@bradcray I have created a PR googlearchive/code-prettify#588

[bradcray]

Hi @krishnadey30 : Unfortunately, there's already a PR for this as noted, albeit somewhat subtly, in a comment above:

googlearchive/code-prettify#518

Unfortunately, it's been open for over a year now with no action on it. I'm not sure how to get the process unstuck, so filed an issue requesting Chapel support to the code-prettify repo recently:

googlearchive/code-prettify#587

But that hasn't resulted in any action either. It might be worth comparing your implementation to the previous to see how they compare.

I mostly don't know how to move this forward if the code-prettify maintainers don't choose to act on it.

[krishnadey30]

@bradcray Sorry for not checking the message properly. I checked it now. I went through the PR and found that some changes are needed.
For eg: null is used instead of nil. Keywords and types are mixed.
@victor-ludorum It will be good if you can update the PR.

Shall I close my PR?

[bradcray]

I think we should do what we can to only have one best PR open so that reviewers on the code-prettify team who don't know Chapel will not have to choose between them and guess which is better; but it doesn't really matter to me which one is open. I would guess that we've added some keywords to the language since Victor opened his, so imagine that the best PR might be a blend of the two?

[krishnadey30]

@bradcray I will once check @victor-ludorum PR properly and will update my files if I missed something.

[ben-albrecht]

We have 2 open PRs and 1 open issue (googlearchive/code-prettify#587) on code-prettify repo. We might need to ping some maintainers to get a review, as the repo seems pretty inactive lately.

What's our game plan for reducing our 2 PRs into 1 that we feel comfortable requesting a review on?

PRs:

• Add chapel language support googlearchive/code-prettify#588
• Add Chapel to the list of supported language googlearchive/code-prettify#518

[krishnadey30]

Hey @ben-albrecht I will try to modify the PR

[bradcray]

It looks as though StackOverflow has moved away from Google Prettify due to lack of support and active development (as we've experienced). So I'm closing this issue in favor of #16454.

[bradcray]

Thanks to @victor-ludorum and @krishnadey30 for wrestling with this, and sorry to set you up for frustration (I'm frustrated by it as well).