Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 6.4 support #42

Closed
maddesigns opened this issue Oct 18, 2021 · 3 comments · Fixed by #46
Closed

Storybook 6.4 support #42

maddesigns opened this issue Oct 18, 2021 · 3 comments · Fixed by #46

Comments

@maddesigns
Copy link

I got a Storybook HTML 6.4.0-beta.13 error for each story:

 Error: page.evaluate: Evaluation failed: TypeError: storybookClientApi.store is not a function
           at emitSetCurrentStory (eval at evaluate (:3:1339), <anonymous>:10:36)
           at t.default.evaluate (<anonymous>:3:1362)
           at t.default.<anonymous> (<anonymous>:1:44)

Anything I’m missing in my setup?

@ahuth
Copy link
Collaborator

ahuth commented Oct 18, 2021

This project uses storybookClientApi.store to display a story, which is an internal Storybook API. My guess is Storybook 6.4 will change the API.

2 options I see for moving forward:

I'll probably wait to release a version supporting Storybook 6.4 until that version is out of beta and officially released.

@maddesigns
Copy link
Author

I stay on 6.3 for now.

@ahuth ahuth changed the title TypeError: storybookClientApi.store is not a function Storybook 6.4 support Nov 8, 2021
@ahuth
Copy link
Collaborator

ahuth commented Nov 8, 2021

Once Storybook 6.4 is released (storybookjs/storybook#15355), I'll merge #46 and publish a new major version of axe-storybook-testing that supports it.

@ahuth ahuth closed this as completed in #46 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants