Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI is not triggered when changesets PR is opened #2189

Closed
yangwooseong opened this issue May 2, 2024 · 0 comments · Fixed by #2190
Closed

Fix CI is not triggered when changesets PR is opened #2189

yangwooseong opened this issue May 2, 2024 · 0 comments · Fixed by #2190
Assignees
@yangwooseong
Labels
bug Issues related to anything that isn't working ci Issue or PR related to continuous integration

Comments

@yangwooseong
Copy link
Collaborator

yangwooseong commented May 2, 2024 •
edited

Summary

changesets PR에서 CI가 돌지 않고 있습니다.

Reproduction process

#2188 가 오픈되었으나 CI가 돌지 않고 있습니다.

Suggestion

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs 에 따르면 GITHUB_TOKEN이 들어간 코드로 workflow가 실행되면 연이어 다른 workflow를 실행할 수 없다고 합니다. changesets/action#187 에서 토큰 네이밍을 변경해서 커스텀 토큰을 만드는 것을 제안하고 있습니다.

Version of bezier-react

2.0.3
@yangwooseong yangwooseong added bug Issues related to anything that isn't working ci Issue or PR related to continuous integration labels May 2, 2024
@yangwooseong yangwooseong self-assigned this May 2, 2024
@channel-io channel-io deleted a comment from channeltalk bot May 2, 2024
@yangwooseong yangwooseong mentioned this issue May 2, 2024
Merged
6 tasks
yangwooseong added a commit that referenced this issue May 2, 2024
@yangwooseong
use PAT(Personal Access Token) for CI trigger of changeset PR (#2190)
cdb8250 
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->

- Fixes #2189 

## Summary

<!-- Please brief explanation of the changes made -->

- 이슈를 참조해주세요

## Details

<!-- Please elaborate description of the changes -->

- 이슈를 참조해주세요.
- 레토 설정에서 `CHANGESET_TOKEN` 시크릿을 추가했습니다.

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

- No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

- None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangwooseong yangwooseong

Labels
bug Issues related to anything that isn't working ci Issue or PR related to continuous integration
Projects
Bezier React
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use PAT(Personal Access Token) for CI trigger of changeset PR yangwooseong/bezier-react
1 participant
@yangwooseong