Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert theme token(props passed by styled-components) to CSS variables #1066

Closed
sungik-choi opened this issue Dec 6, 2022 · 2 comments
Closed

Convert theme token(props passed by styled-components) to CSS variables #1066

sungik-choi opened this issue Dec 6, 2022 · 2 comments
Assignees
@sungik-choi
Labels
enhancement Issues or PR related to making existing features better refactoring Issue or PR related to refactoring with no functional changes status:duplicate Issue or PR that already exists

Comments

@sungik-choi
Copy link
Contributor

sungik-choi commented Dec 6, 2022 •
edited

Description

생략

Reasons for suggestion

#764 (comment)

Proposed solution

#764 (comment)

References
@sungik-choi sungik-choi added enhancement Issues or PR related to making existing features better refactoring Issue or PR related to refactoring with no functional changes labels Dec 6, 2022
@sungik-choi sungik-choi self-assigned this Dec 6, 2022
This was referenced Dec 6, 2022
Merged
Merged
Merged
@sungik-choi sungik-choi mentioned this issue Dec 26, 2022
Merged
9 tasks
@sungik-choi
Copy link
Contributor Author

내부적으로 styled를 떼어내는 방향을 고민해봐야할 수도 있음. SSR 환경(채널 홈페이지)에서 styled-components 사용 시 런타임 에러가 발생.

@sungik-choi sungik-choi mentioned this issue Jan 19, 2023
Closed
@sungik-choi
Copy link
Contributor Author

duplicate

@sungik-choi sungik-choi added the status:duplicate Issue or PR that already exists label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sungik-choi sungik-choi

Labels
enhancement Issues or PR related to making existing features better refactoring Issue or PR related to refactoring with no functional changes status:duplicate Issue or PR that already exists
Projects
Bezier React
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sungik-choi