Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon for non toggled cli options to red cross (a11y issue) #971

Closed
basickarl opened this issue Oct 5, 2022 · 2 comments
Closed

Comments

@basickarl
Copy link

basickarl commented Oct 5, 2022

"@changesets/cli": "^2.22.0",

When trying to toggle whether or not a package is to be included in a changeset in some terminal windows (the one in vscode for example) the unselected green and selected green are hardly different and it is very hard to see what has been accepted:

Unselected:
Screenshot 2022-10-05 at 17 12 18

Selected:
Screenshot 2022-10-05 at 17 12 24

I suggest changing the icon to a red X, this won't only fix issues for certain terminals but for color blind people in general.

@basickarl basickarl changed the title Change icon for non toggled ci options to red cross (a11y) Change icon for non toggled cli options to red cross (a11y) Oct 5, 2022
@basickarl basickarl changed the title Change icon for non toggled cli options to red cross (a11y) Change icon for non toggled cli options to red cross (a11y issue) Oct 5, 2022
@Andarist
Copy link
Member

Andarist commented Oct 5, 2022

I would happily review a PR to improve this situation. Actually, we were adjusting those things somewhat recently - the previous related PR can be found here: #811 . So perhaps you could prepare a new one that would adjust those places in the code?

@basickarl
Copy link
Author

Yapp that was the solution! It's looking great now after the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants