Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types to avoid @ts-ignore #951

Merged
merged 1 commit into from Sep 20, 2022
Merged

Fix types to avoid @ts-ignore #951

merged 1 commit into from Sep 20, 2022

Conversation

Andarist
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

鈿狅笍 No Changeset found

Latest commit: 0535f5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0535f5f:

Sandbox Source
Vanilla Configuration

Andarist
Andarist commented Sep 19, 2022
View reviewed changes
packages/assemble-release-plan/src/determine-dependents.ts
Comment on lines +125 to +130
.filter(
(
dependentItem
): dependentItem is typeof dependentItem & { type: VersionType } =>
!!dependentItem.type
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix is here - I've added a type predicate here and removed @ts-ignore comment targeting the binding pattern in the parameter below

@Andarist Andarist merged commit 911f314 into main Sep 20, 2022
@Andarist Andarist deleted the ts/remote-ts-ignore branch September 20, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Andarist @emmatown