Cannot ignore internal package

[Jack-Works]

Affected Packages

Changesets cli

Problem

I have "ignore": ["install-swc-plugin-test"] in .changeset/config.json, and packages/swc-plugin-test/package.json also marked as private: true and with no version field.

But when I run npx changesets tag, it always includes this package.

~/../aot-secure-ecmascript main  ≡  npx changeset tag
🦋  Skipping tag (already exists):  @masknet/compartment@0.1.0
🦋  Skipping tag (already exists):  @masknet/static-module-record-swc@0.2.1
🦋  Skipping tag (already exists):  install-swc-plugin-test@undefined

Repo: https://github.com/DimensionDev/aot-secure-ecmascript

It fails our CI every release because install-swc-plugin-test@undefined is a duplicated git tag.

CI log:

🦋  New tag:  @masknet/compartment@0.1.0
🦋  New tag:  @masknet/static-module-record-swc@0.2.1
🦋  New tag:  install-swc-plugin-test@undefined
🦋  info npm info @masknet/compartment
🦋  info npm info @masknet/static-module-record-swc
🦋  warn Received 404 for npm info "@masknet/compartment"
🦋  info @masknet/compartment is being published because our local version (0.1.0) has not been published on npm
🦋  warn @masknet/static-module-record-swc is not being published because version 0.2.1 is already published on npm
🦋  info Publishing "@masknet/compartment" at "0.1.0"
🦋  success packages published successfully:
🦋  @masknet/compartment@0.1.0
🦋  Creating git tag...
🦋  New tag:  @masknet/compartment@0.1.0
/usr/bin/git push origin --tags
To https://github.com/DimensionDev/aot-secure-ecmascript
 * [new tag]         @masknet/compartment@0.1.0 -> @masknet/compartment@0.1.0
 * [new tag]         @masknet/static-module-record-swc@0.2.1 -> @masknet/static-module-record-swc@0.2.1
 ! [rejected]        install-swc-plugin-test@undefined -> install-swc-plugin-test@undefined (already exists)
error: failed to push some refs to 'https://github.com/DimensionDev/aot-secure-ecmascript'
hint: Updates were rejected because the tag already exists in the remote.

Proposed solution

Ignore the internal package that is not intended to publish anyway.

[Jack-Works]

I find out a workaround. When checkout the repo on CI, you should check out all commits and tags so that the changeset can skip the duplicated tags.

[Andarist]

I think that the proper fix would be to filter the packages here:
https://github.com/changesets/changesets/blob/0fd56e17092c7258de57adf7dd4ba08406c8e440/packages/cli/src/commands/tag/index.ts
in the same way they are filtered here:

changesets/packages/cli/src/commands/add/index.ts

Lines 19 to 22 in 0fd56e1

	return (
	!config.ignore.includes(packageJson.name) &&
	(packageJson.version || !packageJson.private)
	);

[Jack-Works]

I believe this is fixed by #720?

[Andarist]

Nope - this PR has only fixed an issue with packages like that being listed in the CLI prompt when adding a changeset. You’d like to have this fixed for changeset tag