CircleCI config using outdated convenience images/orbs

[brianespinosa]

Affected Packages

Potentially all packages, depending on dependencies and requirements per node version

Problem

We are seeing a message that we are using a deprecated docker image in our CI setup:

We also have some YAML configuration in our CircleCI settings that are invalid.

Additionally, the version we are using in CI of Node 10.13.0, which is no longer in LTS.

Proposed solution

Upgrade our repository CI to use an updated node orb for CircleCI with an LTS version of Node.

[Andarist]

Hm... I'm somewhat unsure how this affects you. I mean - we don't provide any example CircleCI config for executing Changesets on your CI. So it seems that the problem~ is with your custom configuration 🤔

We might indeed use some outdated docker images in our own CircleCI config but I'm not sure how this would affect consuming projects.

Sorry if I misunderstood the issue.

[brianespinosa]

I will need it in my separate PR adding NX support. Happy to do this for us, btw.

The issue is that if there are any new dependencies, even if they are peerDependencies that get added, they cannot run in our CI environment if they have engines defined in their package.json files stating that they are not compatible with node 10.

Perhaps there is a larger concern here, if we update CI to a newer node version, would we potentially have to state we no longer support node 10? Or, would we need to set up CI with matrix tests to keep running tests on 10?

[brianespinosa]

...actually, we would not have to drop support for Node 10. This is only for a devDependency that is not compatible with our current CI environment.

@Andarist again, I am happy to own doing this. It looks like there are a few other issues and PRs hanging around that I can also help with if you're interested in my participation. I know it sucks getting a waterfall of feature requests and bug reports with little to no offers to help. Kind of not how OSS is supposed to work.

[Andarist]

@Andarist again, I am happy to own doing this. It looks like there are a few other issues and PRs hanging around that I can also help with if you're interested in my participation. I know it sucks getting a waterfall of feature requests and bug reports with little to no offers to help. Kind of not how OSS is supposed to work.

❤️ ❤️ ❤️

I'm happy to accept any PRs and discuss any potential development of Changesets! I have some TODO items of my own to handle here - but lately, I didn't manage to find too much free time to get to those things.

I've seen notifications about your issues/PRs and I plan to read through them soon - I have been away for a week and it will take me a moment to catch up with everything though.

---

As to the support level of node - this gets tricky because Changesets didn't have any explicit support level when I joined the project and it's hard to know what was the expectation here. Ideally, I'd like to avoid breaking changes like that - but if needed I'm willing to consider only supporting LTS versions.

[brianespinosa]

I'll proceed with this then. I think there are a few other areas we could give the toolchain here a minor cleanup as I think some items have not been touched much since they were first set up. I have not created tickets for those items, but I will probably do so later this week.

Feel free to assign this particular ticket over to me if you'd like. I should have a PR up sometime later this week.

[Andarist]

@brianespinosa could you check if this PR has resolved this ticket: #796 ? Or do you believe there is some other work that has to be done here?

[brianespinosa]

@Andarist I am still seeing deprecation messages about convenience images in the CircleCI UI both from that PR itself, as well as for recent PRs from even 4 days ago. There are still a few things that need to get cleaned up.

This is the CircleCI article that the deprecation notice links to.

Sorry for the slow response. Big changes at work going on and I've been pulled into lots of other directions.