Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The Guild libraries to list of Changesets adopters #792

Merged
merged 4 commits into from Aug 17, 2022

Conversation

dotansimha
Copy link
Contributor

@dotansimha dotansimha commented Apr 25, 2022

Hi there!

We at The Guild are huge fans of Changesets.

We are using it in popular libs like graphql-yoga, GraphQL Code Generator, graphql-tools and a lot more (~20 more repos).

We are using most of Changesets features and also extended it with some custom configurations (like publishing canary/alpha releases based on changesets for each in-progress PR).

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2022

⚠️ No Changeset found

Latest commit: 0c38292

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c38292:

Sandbox Source
Vanilla Configuration

@Andarist
Copy link
Member

Thank you for your PR! I am slightly torn on what I should do with it though. There are two aspects here that I take into consideration:

  • The Guild is a company and not a single project, everything else on the list is a project. I understand that this somewhat acts as an umbrella for all of the projects that you maintain but the point stands.
  • the list already is somewhat long and it can grow somewhat indefinitely with time

I'm not saying that I don't want to merge this - I'm just considering, in general, what's the best course of action here. I think that ideally I would like to replace the vertical list with a list of logos that could be wrapped horizontally - with such in place I wouldn't object to including The Guild as a whole on the list. But perhaps right now I would prefer this to be replaced with a project or two.

Note that this is mostly me thinking out loud - if you have any other point of view on the matter I would happily discuss this further, don't feel obliged to make any changes right away.

@dotansimha
Copy link
Contributor Author

Thanks @Andarist , I agree with your take on this one. I updated the PR and added a list of projects :)

@dotansimha dotansimha changed the title Add The Guild to list of Changesets adopters Add The Guild libraries to list of Changesets adopters Jun 27, 2022
README.md Outdated Show resolved Hide resolved
dotansimha and others added 3 commits June 28, 2022 13:12
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@Andarist Andarist merged commit 8e64d41 into changesets:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants