New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix formatting of summary in cli workflow #560
Comments
I've looked into why this box was wrongly formatted - we are using
As to colors - do you just propose to color major/minor/patch "labels"? Not sure if I understand the latter part - I mean, not sure exactly how the proposed formatting mimics how packages are formatted in questions. A visual would be helpful for this.
Agreed, not completely sure how we should treat major CLI output revamps in relation to semver. I'm inclined to say that we can be liberal about this though.
+1 on merging "Summary" and "Realising..." headers |
This all sounds good to me. |
@Andarist I just meant that currently the two places that display the "minor" concept in that screenshot are using two different types of formatting. (1) is using lowercase, color, bold. (2) is using uppercase, square brackets, non-bold, color. My suggestion is to unify on (1). |
…style of text font, discussion in changesets#560
…style of text font, discussion in changesets#560
…style of text font, discussion in changesets#560
* Make cli log message clear, reduce noise "boxen" style, unify visual style of text font, discussion in #560 * Tweak changeset * Fix linting problems Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Affected Packages
pkg:cli
Problem
The summarization of a changeset in the CLI is a nice idea, but right now the formatting seems broken:
Proposed solution
I think if you open the editor to write the changeset (instead of doing it directly in the terminal) the summary step should be eliminated. Because you've already just seen the entire changeset file and have saved and closed it.
The formatting should be fixed and simplified. Potentially something like this:
Which includes things like:
major/minor/patch
. Again color will get the job done. (And the formatting I've used mimics how they are formatted in the questions already, which is good.)The text was updated successfully, but these errors were encountered: