How can i make sure that every PR has a changeset or not #1119
Replies: 4 comments
-
|
Beta Was this translation helpful? Give feedback.
-
main is our root branch where all the pr are merged . When a PR is merged the .changeset file gets added with a changeset.md file . I am giving you example of the file structure how to will look like of the brancg feat/to-do now if do a npm run changeset status --since=main it will not throw an error since the the branch already has couple of changeset.md file |
Beta Was this translation helpful? Give feedback.
-
Hm, I took a look into how changesets/packages/read/src/index.ts Lines 37 to 43 in 1ea308a So... I think that it should work. If you manage to write a failing test case in our repo for this then I could take a look at it, investigate, and provide a fix. I could also just accept a PR (with a test case) if you manage to fix your issue. Without those... I'm not sure how to investigate this on my own. From my PoV, it should just work today. |
Beta Was this translation helpful? Give feedback.
-
Hey Andarist , Thanks for your help yess changeset status --since=main resolve the issue ... I had not defined it inside my script tag in package.json and was trying to do an npm run changeset --status . I was able to connect the it to the husky pre-commits aswell. |
Beta Was this translation helpful? Give feedback.
-
Hey Everyone , i am using changeset for generating changelog generation and version update . Sometimes some PR's dont have a changeset file and they are pushed to main .We are a team of seven and regularly push pr and do a version update in every 14 days.
I went through the recommended solution i cannot use changeset bot or github actions
The command changeset status --since=main never breaks beacuse there are changeset generated from other developers are there in our latest branches . Is there any other process i can use to enable my pr's dont miss a changeset ?
Beta Was this translation helpful? Give feedback.
All reactions