Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot reporting "No Changeset found", but there is. How to debug? #78

Open
chizmw opened this issue Jul 18, 2023 · 3 comments
Open

Bot reporting "No Changeset found", but there is. How to debug? #78

chizmw opened this issue Jul 18, 2023 · 3 comments

Comments

@chizmw
Copy link

chizmw commented Jul 18, 2023

I've been exploring changesets recently and am in a mostly good place.

I have it working in three repos as expected.

One repo confused the bot in ways I can't understand. I keep getting:

🦋 No Changeset found

no matter what I try.

My current status:

  • new branch in repo
  • deleted all the files
  • ran the usual:
    • yarn init
    • yarn add @changesets/cli && yarn changeset init
    • modify "commit" to true in config
    • git add .changeset/ package.json yarn.lock
    • git commit
    • git oush -u

Then I create and view the PR.

🦋 No Changeset found

This is a summary of the branch:

❯ /bin/ls -a
.                       .markdownlint.jsonc     node_modules
..                      .markdownlintignore     package.json
.changeset              .pre-commit-config.yaml terraform
.git                    .pytest_cache           yarn.lock
.infracost              .venv
❯ tree .changeset/
.changeset/
├── README.md
├── config.json
└── weak-beans-share.md

1 directory, 3 files

and

❯ cat .changeset/weak-beans-share.md
---
'botc-custom-script-json2pdf': patch
---

add changeset tool

I'm stumped, and don't know where to look for issues, not what to try to get the bot working as expected in this repo.

Any and all suggestions welcome.

@chizmw
Copy link
Author

chizmw commented Jul 18, 2023

Not fully solving the issue, but possibly a pointer to the root cause, I found that removing changie files

  • .changes/
  • .changie.yaml

appears to confuse the bot in some way.

In a different branch where I only add the changesets tooling, and do not remove any files I see:

🦋 Changeset detected

If I run:

git rm -r .changie.yaml .changes/
git commit -m 'remove changie'
git push

the PR comment is updated to:

⚠️ No Changeset found

.changeset/ still exists after the previous operation:

❯ tree .changeset/
.changeset/
├── README.md
├── config.json
└── fair-walls-join.md

@chizmw
Copy link
Author

chizmw commented Jul 18, 2023

Renaming the files does not immediately confuse the bot:

git mv .changes .no-more-changie
git commit -m 'git mv .changes .no-more-changie' --no-verify
git push

still gives the expected:

🦋 Changeset detected

However, even after renaming, removing the files confuses the bot again:

git rm -rf .no-more-changie
git commit -m 'git rm .no-more-changie' --no-verify
git push

puts us back to:

⚠️ No Changeset found

@chizmw
Copy link
Author

chizmw commented Jul 18, 2023

❓ is there a limit to the number of results/files returned in octocat calls?

I have another PR in a different repo where I believe I followed the same process and the bot's fine.

The only obvious difference I can see is "Files Changed: 81" versus "Files Changed: 18"

Note: Responses include a maximum of 3000 files. The paginated response returns 30 files per page by default.

source: https://octokit.github.io/rest.js/v19#pulls-list-files

chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 26, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 26, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 26, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
- maybe get round the problem in
  changesets/bot#78 by removing fewer files at
  a time
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
chizmw added a commit to chizmw/botc-custom-script-json2pdf that referenced this issue Aug 27, 2023
docs(changeset): chore: trigger changesets (ref: changesets/bot#78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant