Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Generate tags on PRs based on changesets #5

Open
timleslie opened this issue Nov 7, 2019 · 1 comment
Open

Feature request: Generate tags on PRs based on changesets #5

timleslie opened this issue Nov 7, 2019 · 1 comment

Comments

@timleslie
Copy link

For my project we have a convention of listing the packages being touched in a PR in the title, so the pull request page will look something like:

  • package-A: Add new feature
  • package-B,package-C: Fix some bugs
  • pkg-D: Do some work

This is an error prone, inconsistent, non-filterable system. It occurs to me that we could be using tags rather than coding this info in the PR title. If we're going to do that, then we could take advantage of the changeset-bot to do this automatically for us. It will be able to give us more consistent data and will also make it obvious at a glance what kinds of changes are in the PR pipeline.

The tags would probably be something like package-name - major for e.g.

This tagging solution might not be appropriate for all users of the changeset bot, so it would probably make sense for it to be an option feature which can be switched on/off.

@Noviny
Copy link
Contributor

Noviny commented Nov 7, 2019

I'm a bit hesitant to use github tags for something like this, as it seems like it would make tags be quite loud.

Quick q: When does this information get referenced? Just in the PR, or does it get referenced ✨ the future ✨ as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants