Replace level list with table in readme.md #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevva
suggested changes
Sep 30, 2019
kevva
reviewed
Sep 30, 2019
| @@ -132,12 +132,12 @@ If you need to change this in a reusable module, create a new instance: | |||
| const ctx = new chalk.Instance({level: 0}); | |||
| ``` | |||
|
|
|||
| Levels are as follows: | |||
There was a problem hiding this comment.
It seemed like the heading row of the table communicates the same information.
I am happy to put it back if you prefer.
There was a problem hiding this comment.
Indeed, I guess they do. I don't have a strong opinion about it so let's remove it for now unless somebody else wants to keep it.
kevva
approved these changes
Sep 30, 2019
|
Good catch, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this excellent package <3
To use 256 background colors when available, I tripped over 0-based versus 1-based
levelAlthough
readme.mdhas 0-based numbered list, here is picture of the list onnpmpage:Here is picture of the proposed table in markdown preview of code editor:
Updated picture according to review comments: