Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote complex keys in objects #45

Closed
pcorpet opened this issue Jun 10, 2021 · 1 comment · Fixed by #46
Closed

Quote complex keys in objects #45

pcorpet opened this issue Jun 10, 2021 · 1 comment · Fixed by #46
Labels
released

Comments

@pcorpet
Copy link
Contributor

pcorpet commented Jun 10, 2021

Currently inspection of an object with a complex key (e.g. with a dot) returns something that is not syntactically valid.

See chaijs/chai#1401 (comment)

loupe.inspect({'a.b': 1})

returns { a.b: 1 } but we would prefer { 'a.b': 1}
pcorpet added a commit to pcorpet/loupe that referenced this issue Jun 10, 2021
@pcorpet
fix: ensure complex object keys are quoted
b4dea33 
Fix chaijs#45
@pcorpet pcorpet mentioned this issue Jun 10, 2021
Merged
pcorpet added a commit to pcorpet/loupe that referenced this issue Jun 10, 2021
@pcorpet
fix: ensure complex object keys are quoted
c9253e0 
Fix chaijs#45
keithamus added a commit that referenced this issue Jun 24, 2021
@pcorpet @keithamus
fix: ensure complex object keys are quoted (#46)
917757d 
* fix: ensure complex object keys are quoted

Fix #45

* style: add spacing

* style: spacing

Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
@github-actions
Copy link

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure complex object keys are quoted pcorpet/loupe
1 participant
@pcorpet