Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document supported browsers #6

Open
shvaikalesh opened this issue Oct 9, 2016 · 2 comments
Open

Document supported browsers #6

shvaikalesh opened this issue Oct 9, 2016 · 2 comments

Comments

@shvaikalesh
Copy link

shvaikalesh commented Oct 9, 2016 •
edited

I believe the same runtimes we support in Chai: Node 0.10 (soon 0.12), IE 9+, latest Safari/Chrome/Firefox, Firefox ESR.

EDIT: if we agree on this, regular expression used to extract function name from it's source code could be a bit simplified.
@keithamus
Copy link
Member

Proposal for simplification @shvaikalesh?

@shvaikalesh
Copy link
Author

Node 0.10+ is good with names, so are the latest Safari/Chrome/Firefox, Firefox ESR. RegExp is only for IE9+. Thus we can drop handling comments (tried IE10, latest Safari/Chrome/Firefox, they all omit comments), methods (we don't), generators in regexp to make it faster & more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keithamus @shvaikalesh