From b782614bd12fed97e8ccc2cda91adc79696373a2 Mon Sep 17 00:00:00 2001 From: ScottRudiger Date: Thu, 13 Sep 2018 12:05:50 -0700 Subject: [PATCH 1/2] feat(assertions): add 'still' language chain --- lib/chai/core/assertions.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/chai/core/assertions.js b/lib/chai/core/assertions.js index f2d2153b8..cabcf622f 100644 --- a/lib/chai/core/assertions.js +++ b/lib/chai/core/assertions.js @@ -33,16 +33,17 @@ module.exports = function (chai, _) { * - same * - but * - does + * - still * * @name language chains * @namespace BDD * @api public */ - [ 'to', 'be', 'been' - , 'is', 'and', 'has', 'have' - , 'with', 'that', 'which', 'at' - , 'of', 'same', 'but', 'does' ].forEach(function (chain) { + [ 'to', 'be', 'been', 'is' + , 'and', 'has', 'have', 'with' + , 'that', 'which', 'at', 'of' + , 'same', 'but', 'does', 'still' ].forEach(function (chain) { Assertion.addProperty(chain); }); From 7e5f67c5c789c125fcc012a7127c3627d8c47fb1 Mon Sep 17 00:00:00 2001 From: ScottRudiger Date: Sun, 16 Sep 2018 05:01:15 -0700 Subject: [PATCH 2/2] test: incorporate 'still' language chain into tests --- test/expect.js | 8 ++++---- test/should.js | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/expect.js b/test/expect.js index 3a33f7fae..9b4f485b8 100644 --- a/test/expect.js +++ b/test/expect.js @@ -230,10 +230,10 @@ describe('expect', function () { expect([1, 2, 3])[chain].contains(1); } - [ 'to', 'be', 'been' - , 'is', 'and', 'has', 'have' - , 'with', 'that', 'which', 'at' - , 'of', 'same', 'but', 'does' ].forEach(test); + [ 'to', 'be', 'been', 'is' + , 'and', 'has', 'have', 'with' + , 'that', 'which', 'at', 'of' + , 'same', 'but', 'does', 'still' ].forEach(test); }); describe("fail", function() { diff --git a/test/should.js b/test/should.js index 0bfe44d91..9a2400dfb 100644 --- a/test/should.js +++ b/test/should.js @@ -227,10 +227,10 @@ describe('should', function() { [1, 2, 3].should[chain].contains(1); } - [ 'to', 'be', 'been' - , 'is', 'and', 'has', 'have' - , 'with', 'that', 'which', 'at' - , 'of', 'same', 'but', 'does' ].forEach(test); + [ 'to', 'be', 'been', 'is' + , 'and', 'has', 'have', 'with' + , 'that', 'which', 'at', 'of' + , 'same', 'but', 'does', 'still' ].forEach(test); }); describe("fail", function() {