Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officia type definitions for 5.x? #1554

Open
justinfagnani opened this issue Dec 20, 2023 · 6 comments
Open

Officia type definitions for 5.x? #1554

justinfagnani opened this issue Dec 20, 2023 · 6 comments

Comments

@justinfagnani
Copy link

I notice that there are no type definitions for the 5.x branch, here or in Definitely Typed. Is there a chance of getting official types with the 5.x releases?

@keithamus
Copy link
Member

PRs welcome for adding official types.

@43081j
Copy link
Contributor

43081j commented Dec 21, 2023

we could generate types via --declarationOnly in tsc if we correct all the jsdoc, but its a chunky job

so maybe for now we just store hand written types alongside the sources? i can probably have a stab at it at some point

@justinfagnani
Copy link
Author

I'm hesitant to ask, but... it's there any appetite for a contribution of a port of the source to TypeScript syntax?

@43081j
Copy link
Contributor

43081j commented Dec 21, 2023

Tbh I would rather do that than work around it producing types from the js

If everyone's up for that I can probably sort it out

@justinfagnani
Copy link
Author

I could contribute too, though you might be faster.

I wonder if given the existing npm scripts, if Wireit would be a good addition to make sure everything's built before other scripts that need that.

@koddsson
Copy link
Member

Started a draft PR here. I'll be slogging through the types and trying to get them all done before the new year but who knows how long it will take :D

#1557

Feel free to help out by making PRs against this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants