Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it possible to bump deep-eql to ^4.0.0 in chai 4.x.x #1473

Open
Ucandoit opened this issue Jul 11, 2022 · 4 comments
Open

is it possible to bump deep-eql to ^4.0.0 in chai 4.x.x #1473

Ucandoit opened this issue Jul 11, 2022 · 4 comments

Comments

@Ucandoit
Copy link

Ucandoit commented Jul 11, 2022

Hi, now that this PR is merged in deep-eql chaijs/deep-eql#88, I'd like to make a new release of chai so that we can fix the bug of comparison in Temporal objects.
I figured out that in chai 4.x.x, the deep-eql version is set to ^3.0.1. Do you have any idea why it stays in v3 and whether I can bump its version to ^4.0.0?
It seems that all tests pass when I bump to 4.1.0 in local environment

@keithamus
Copy link
Member

Chai v4 cannot use v4 of deep-eql because it includes breaking changes around error comparison (https://github.com/chaijs/deep-eql/releases/tag/v4.0.0).

It may be worth making a Chai v5 release which upgrades these, while also dropping support for old versions of Node & IE to allow us to make more changes to support newer features.

@Ucandoit
Copy link
Author

OK I see. What's the status of v5? Is it releasable or there are stuffs to finish before releasing?

@keithamus
Copy link
Member

We had plans to make some more sweeping changes in v5 but it might be too much in one go. So I think we should just cut a v5 which drops support for old engines and lets us do the bigger changes in v6

@koddsson
Copy link
Member

koddsson commented Jan 24, 2024

@Ucandoit what do you think we should do here now that chai v5 is out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants