Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use chaijs/loupe for inspection #1407

Merged
merged 1 commit into from Jul 8, 2021
Merged

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Jul 5, 2021

For #1228

Backport of #1401 in branch 4.x.x

@pcorpet pcorpet requested a review from a team as a code owner July 5, 2021 15:11
@keithamus
Copy link
Member

Thanks for this @pcorpet! I’ll merge this and we can look to cut a pre-release for testing in the wild.

@keithamus keithamus merged commit c8a4e00 into chaijs:4.x.x Jul 8, 2021
}, "expected { tea: \'chai\' } to deeply equal { tea: \'black\' }");
}, "expected {} to deeply equal {}");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't the old message more descriptive?

keithamus added a commit that referenced this pull request Feb 7, 2023
* Fixed a regression that caused SyntaxErrors on IE 11

The changes made in #1334 incorrectly used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai.

* chai@4.3.2

* export chai.Assertion (#1378)

* chai@4.3.3

* fix: support inspecting bigints (#1321) (#1383)

* 4.3.4

* feat: use chaijs/loupe for inspection (#1401) (#1407)

Fix #1228

* fix: package.json - deprecation warning on exports field (#1400)

* fix package.json exports

* build(deps-dev): bump codecov from 3.1.0 to 3.7.1 (#1446)

Bumps [codecov](https://github.com/codecov/codecov-node) from 3.1.0 to 3.7.1.
- [Release notes](https://github.com/codecov/codecov-node/releases)
- [Changelog](https://github.com/codecov/codecov-node/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-node@v3.1.0...v3.7.1)

---
updated-dependencies:
- dependency-name: codecov
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build chaijs

* 4.3.5

* fix: use loupe@^2.3.1

* build chaijs

* 4.3.6

* fix: deep-eql bump package to support symbols comparison (#1483)

* 4.3.7

* build

* chore: 4.x.x: Fix link to commit logs on GitHub (#1487)

* 4.x.x: Fix link to commit logs on GitHub

As there is no `master` branch, the link returned a 404.

* Update History.md

Co-authored-by: Andre Meyering <info@andremeyering.de>

Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>

* build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (#1488)

Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test: fix typo in test.js (#1459)

* docs: specify return type of objDisplay (#1490)

previously it was incorrectly labeled as `objDisplay(obj: object): void` in `@types/chai`.

* feat: rework into ES modules

This moves all of the sources to be ES modules rather than CommonJS.

In order to produce the entrypoints, we use esbuild as a bundler (and as
a transpiler in a way).

Due to the fact that some dependencies are written in CommonJS, we
actually use esbuild to create _two_ bundles: a CommonJS bundle, and an
ES module bundle.

Otherwise, someone importing the raw source would inevitably end up
trying to import a CommonJS module somewhere down the tree, which would
not work in browsers natively.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Lee Newson <lnewso@hotmail.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: rbruckheimer <rob@cosaic.io>
Co-authored-by: Mike Frysinger <vapier@gmail.com>
Co-authored-by: Pascal Corpet <pcorpet@users.noreply.github.com>
Co-authored-by: Mimi <stevenjoezhang@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Scott Newcomer <snewcomer@users.noreply.github.com>
Co-authored-by: Andre Meyering <info@andremeyering.de>
Co-authored-by: Mavaddat Javid <5055400+mavaddat@users.noreply.github.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: James Garbutt <james.garbutt@crispthinking.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants