Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add also language chain #1324

Merged
merged 2 commits into from Feb 4, 2021
Merged

Add also language chain #1324

merged 2 commits into from Feb 4, 2021

Conversation

sportshead
Copy link
Contributor

This would be helpful, as the property doesn't clash with other methods.

This would be helpful, as the property doesn't clash with other methods.
@sportshead sportshead requested a review from a team as a code owner March 19, 2020 11:12
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1324 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          33       33           
  Lines        1708     1708           
  Branches      416      416           
=======================================
  Hits         1616     1616           
  Misses         92       92           
Impacted Files Coverage Δ
lib/chai/core/assertions.js 99.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2b25c...0729871. Read the comment docs.

@keithamus
Copy link
Member

Thanks for the PR @sportshead! I'm not sure how this will clash with other plugins and the like, so we might have to hold off on merging this just yet before doing more research.

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Let's add it!

@keithamus keithamus merged commit 77565f7 into chaijs:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants