Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbalanced quotes in assert.notInclude example #1200

Merged
merged 1 commit into from Sep 25, 2018

Conversation

haykam821
Copy link
Contributor

This pull request fixes two lines in the example for assert.notInclude using single quotes around the string but also including a single quote in the string:

'this doesn't work'

I have changed the erroneous examples to use double quotes around the string instead, so there is no longer a syntax error:

"this doesn't break!"

Some of the examples in assert.notInclude used quotes in the string and for the string itself, so it now uses double quotes to prevent the single quote from breaking the syntax.
@haykam821 haykam821 requested a review from a team as a code owner September 24, 2018 18:52
@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #1200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1200   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          32       32           
  Lines        1676     1676           
  Branches      404      404           
=======================================
  Hits         1584     1584           
  Misses         92       92
Impacted Files Coverage Δ
lib/chai/interface/assert.js 93.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0064f26...c9eacb7. Read the comment docs.

@keithamus keithamus merged commit ed93c93 into chaijs:master Sep 25, 2018
@astorije
Copy link
Member

@meeber, @keithamus, npmjs has recently invalidated all tokens, so a new one needs to be set up in the .travis.yml config file. I hit the same issue very recently at thelounge/thelounge#2716.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants