Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The assert.fail([message]) format should be supported for compatibility with NodeJS assert interface #1116

Closed
s-leroux opened this issue Jan 5, 2018 · 0 comments
Closed

The assert.fail([message]) format should be supported for compatibility with NodeJS assert interface #1116

s-leroux opened this issue Jan 5, 2018 · 0 comments

Comments

@s-leroux
Copy link
Contributor

s-leroux commented Jan 5, 2018

The NodeJS assert interface supports being called with 1 (or 0) arguments:
https://nodejs.org/api/assert.html#assert_assert_fail_message

But currently Chai's assert.fail only supports being called with 2 (or more arguments) leading to that idiom to fail with a custom error message:

assert.fail(0,1, "Custom error message");

The interface should be modified so we can write that instead:

assert.fail("Custom error message");
s-leroux added a commit to s-leroux/chai that referenced this issue Jan 5, 2018
@s-leroux
Add the assert.fail([message]) interface [chaijs#1116]
84a378e
@s-leroux s-leroux mentioned this issue Jan 5, 2018
Merged
s-leroux added a commit to s-leroux/chai that referenced this issue Jan 5, 2018
@s-leroux
feat: Add the assert.fail([message]) interface
8f7addc 
In relation to chaijs#1116, the `assert.fail` interface should accept
ibeing called with only 1 arguments to fail with a custom message.
s-leroux added a commit to s-leroux/chai that referenced this issue Jan 11, 2018
@s-leroux
feat: Add the .fail([message]) interface
833324d 
Fix chaijs#1116.
The `assert.fail` interface should accept being called with
only 1 arguments to fail with a custom message.
s-leroux added a commit to s-leroux/chai that referenced this issue Jan 11, 2018
@s-leroux
feat: Add the .fail([message]) interface
bde6607 
Fix chaijs#1116.
The `assert.fail` interface should accept being called with
only 1 arguments to fail with a custom message.
s-leroux added a commit to s-leroux/chai that referenced this issue Jan 11, 2018
@s-leroux
feat: Add the .fail([message]) interface
8a987b4 
Fix chaijs#1116.
The `assert.fail` interface should accept being called with
only 1 arguments to fail with a custom message.
@meeber meeber closed this as completed in 0d1b586 Jan 12, 2018
@snyk-bot snyk-bot mentioned this issue Jan 29, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s-leroux