Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve throws examples #1113

Merged
merged 1 commit into from Jan 4, 2018
Merged

Conversation

ColinEberhardt
Copy link
Contributor

When throws is invoked with two arguments, where the second is a string or regexp, the second argument is the errMsgMatcher. The current examples imply that this string is the message rather than the matcher.

When throws is invoked with two arguments, where the second is a string or regexp, the second argument is the **errMsgMatcher**. The current examples imply that this string is the **message**  rather than the matcher.
@ColinEberhardt ColinEberhardt requested a review from a team as a code owner January 4, 2018 06:51
@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #1113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1113   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          32       32           
  Lines        1628     1628           
  Branches      393      393           
=======================================
  Hits         1524     1524           
  Misses        104      104
Impacted Files Coverage Δ
lib/chai/interface/assert.js 89.83% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c1a99f...902852d. Read the comment docs.

Copy link
Member

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants