Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'catch' keyword to proxyExcludedKeys #1101

Merged
merged 1 commit into from Dec 10, 2017
Merged

add 'catch' keyword to proxyExcludedKeys #1101

merged 1 commit into from Dec 10, 2017

Conversation

generalandrew
Copy link
Contributor

closes #1050

@generalandrew generalandrew requested a review from a team as a code owner December 4, 2017 22:55
@codecov
Copy link

codecov bot commented Dec 4, 2017 •
edited

Codecov Report

Merging #1101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1101   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          32       32           
  Lines        1628     1628           
  Branches      393      393           
=======================================
  Hits         1524     1524           
  Misses        104      104
Impacted Files Coverage Δ
lib/chai/config.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae99d1...7d5edda. Read the comment docs.

@generalandrew generalandrew changed the title add 'catch' keyword to proxyExcluedKeys add 'catch' keyword to proxyExcludedKeys Dec 4, 2017
lucasfcosta
lucasfcosta approved these changes Dec 10, 2017
View reviewed changes
Copy link
Member

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the contribution 😄

Next reviewer, please feel free to merge if you approve as well.

@keithamus keithamus merged commit 0af30b7 into chaijs:master Dec 10, 2017
@generalandrew generalandrew deleted the add-catch-to-proxyExcludedKeys branch December 13, 2017 01:27
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfcosta lucasfcosta lucasfcosta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'catch' to proxyExcludedKeys
3 participants
@generalandrew @lucasfcosta @keithamus