Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement build sequence (codecov) #1077

Closed
sukrosono opened this issue Nov 2, 2017 · 1 comment
Closed

Improvement build sequence (codecov) #1077

sukrosono opened this issue Nov 2, 2017 · 1 comment

Comments

@sukrosono
Copy link
Contributor

Well i am too excited to contribute to chai, so previous work #1073 seems have better way.
It's just 300kb , but in my point of view it save developers time to install it and save small disk space 馃槃 .
image
The better way is via bash.

@keithamus
Copy link
Member

Closing because:

I feel really uncomfortable downloading and executing aribtrary bash on my local machine, and on CI (where we have secret tokens like account passwords). The 300k is only downloaded for developers, so I think it's adequete to keep it. I'll close this issue, you did the right thing in the original PR, and changing to running arbitrary bash would be a bad move IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants