Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: change coverage service (coverall to codecov) #1073

Merged
merged 1 commit into from Oct 30, 2017

Conversation

sukrosono
Copy link
Contributor

The reason of change mentioned on #927
This patch:
- add codecov as devDep, as it's not pre-installed by travis.
- add codecov on travis's script section.
- change badge link (coverall to codecov), and point the image to chai account on codecov.
Fix #927

  The reason of change mentioned on chaijs#927
  This patch:
    - add codecov as devDep, as it's not pre-installed by travis.
    - add codecov script on travis.
    - change badge link (coverall to codecov), and point the image to chai account on codecov.
  Fix chaijs#927
@sukrosono sukrosono requested a review from a team as a code owner October 29, 2017 15:14
@sukrosono
Copy link
Contributor Author

Just reminder, since the badge link is pointing to chai account on codecov. Kindly complete the sign-up process on codecov.

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thoughts @chaijs/chai?

Copy link
Contributor

@meeber meeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we need to do something with "Kindly complete the sign-up process on codecov" before merging?

@keithamus
Copy link
Member

I just did it. We're good to merge 😄

@meeber meeber merged commit 2eafe73 into chaijs:master Oct 30, 2017
@keithamus
Copy link
Member

Good work @brutalcrozt 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants