Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary code #1049

Merged
merged 4 commits into from Sep 13, 2017
Merged

Remove unnecessary code #1049

merged 4 commits into from Sep 13, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Sep 12, 2017

  • Remove unnecessary line feeds
  • Remove unused variable declaration
  • Remove meaningless processing (lib/chai/utils/inspect.js)
    • numLinesEst does not seem to be used anywhere after this.

It is not a remove, but changed to a single quote unified to other coding styles. ('number' of lib/chai/core/assertions.js)

@abetomo abetomo requested a review from a team as a code owner September 12, 2017 10:15
astorije
astorije previously approved these changes Sep 13, 2017
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job, @abetomo!
Could you squash commits 2 and 3 (the unused variable removals) together though?

Thanks!!

@abetomo
Remove unused variable declaration
7d1e815 
in utils/getMessage.js

in core/assertions.js
@abetomo
Fix string enclosed in single quotes in core/assertions.js
62baf22 
In other code in this file, the string was enclosed in single quotes
@abetomo
Remove meaningless processing
1c1b074 
numLinesEst does not seem to be used anywhere after this.
@abetomo
Copy link
Contributor Author

abetomo commented Sep 13, 2017

@astorije Thanks for the review.
I squashed the commitment.

@keithamus keithamus merged commit 19e2c18 into chaijs:master Sep 13, 2017
@abetomo abetomo deleted the clean_code branch September 13, 2017 21:36
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abetomo @astorije @keithamus