Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable declaration #1048

Merged
merged 2 commits into from Sep 12, 2017
Merged

Fix variable declaration #1048

merged 2 commits into from Sep 12, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Sep 12, 2017

  • Fix to declare before using actual
  • Remove unused variables

@abetomo abetomo requested a review from a team as a code owner September 12, 2017 02:25
astorije
astorije approved these changes Sep 12, 2017
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@keithamus keithamus merged commit 0d19b35 into chaijs:master Sep 12, 2017
@abetomo abetomo deleted the fix_variable_declaration branch September 12, 2017 09:18
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abetomo @astorije @keithamus