Solve issue with viewing captcha over SSH on Linux #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix was made due to an issue caused by Image.open(f).show() finding xdg-open on Linux (one of the supported viewers per the source https://pillow.readthedocs.io/en/stable/reference/ImageShow.html#PIL.ImageShow.UnixViewer) but xdg-open not having a viewer configured. This resulted in a forever loop as xdg-open never 'fails' thus an exception is never raised.
|
@stevemac007, the tests are failing due to a missing GITHUB_TOKEN in the step config (https://github.com/cevoaustralia/aws-google-auth/runs/7348538918?check_suite_focus=true#step:6:243) which is fixed in a previous PR #262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #265