-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing button Add translation #835
Comments
Hi Maja
You can add new languages only when the SL is in state of ready to be
translated. So the workflow should be. Create a new SL language (do not
forget to finish the DA translation, or forget it) and then after it goes
to the status of ready to be translated, you can add new languages. And als
the other translations show as drafts too.
Cheers Martin
…On Thu, Jan 25, 2024 at 10:09 AM MajaDolinar ***@***.***> wrote:
A button to add new translations to CVs is missing. I wanted to add a
Slovenian translation to DDI Contributor Role, but I could not.
I checked through my ADMIN-CONTENT role and ADMIN-TL Slovenian role. There
is no way to add a new language (eg. Slovenian) to an already published CV.
See pictures:
image.png (view on web)
<https://github.com/cessda/cessda.cvs.two/assets/72601736/ab106a03-a667-4d85-a60b-ce3ea8fbe1ca>
image.png (view on web)
<https://github.com/cessda/cessda.cvs.two/assets/72601736/b6173e2d-4da2-4626-b919-0ab0891694a7>
—
Reply to this email directly, view it on GitHub
<#835>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB23PTQES4RSJNOHCUUPXMTYQIOLJAVCNFSM6AAAAABCKE25WSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TSOJRGAYDOOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hi, so in if you want to add a completely new language you need to create first a new SL version, which means that the versioning is changing to 1.1.0 even though the content of the SL CV has not changed? |
Hi Maja
I do not remember why this approach was selected, it's too old change, but
there was a reason for that. I am pretty sure, because I was thinking the
same as you, there was possibility to do ii that way, but something was
wrong with that approach.
Martin
…On Thu, Feb 1, 2024, 15:10 MajaDolinar ***@***.***> wrote:
Hi, so in if you want to add a completely new language you need to create
first a new SL version, which means that the versioning is changing to
1.1.0 even though the content of the SL CV has not changed?
That does not make sense to me and the workflow does not work like it
should. In my understanding it should be able to add new languages (also
the ones that do not exist yet) to an existing SL version (and b adding
languages, changing only the third digit when published). I do not see the
option to do this at this point.
—
Reply to this email directly, view it on GitHub
<#835 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB23PTQNDJ56H36G5CSCSUTYROO6RAVCNFSM6AAAAABCKE25WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGQYTQMBYHE>
.
You are receiving this because you commented.Message ID: <cessda/cessda.
***@***.***>
|
Hi Maja
Stefan found this requirement:
#398 (comment)
from Tain. So it means, that the publish vocabulary works as a bundle
publishing.
Cheers Martin
On Thu, Feb 1, 2024 at 3:14 PM Martin Šeleng ***@***.***>
wrote:
… Hi Maja
I do not remember why this approach was selected, it's too old change, but
there was a reason for that. I am pretty sure, because I was thinking the
same as you, there was possibility to do ii that way, but something was
wrong with that approach.
Martin
On Thu, Feb 1, 2024, 15:10 MajaDolinar ***@***.***> wrote:
> Hi, so in if you want to add a completely new language you need to create
> first a new SL version, which means that the versioning is changing to
> 1.1.0 even though the content of the SL CV has not changed?
> That does not make sense to me and the workflow does not work like it
> should. In my understanding it should be able to add new languages (also
> the ones that do not exist yet) to an existing SL version (and b adding
> languages, changing only the third digit when published). I do not see the
> option to do this at this point.
>
> —
> Reply to this email directly, view it on GitHub
> <#835 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB23PTQNDJ56H36G5CSCSUTYROO6RAVCNFSM6AAAAABCKE25WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGQYTQMBYHE>
> .
> You are receiving this because you commented.Message ID: <cessda/cessda.
> ***@***.***>
>
|
Dear Martin, Best, |
@Lorenz1983 in my opinion, if the community needs it, it can be there, but if you look at the discussion with Taina (that time Service Owner) 2 years ago, she suggest to publish the vocabularies as a bundles. So I think we can set it as won't fix. But you can ask the user community. Or if it comes from them, we can discuss it further. |
@pakoselo thank you for your feedback. I'll ask the community. If I don't receive any feedback in a timely manner, we can set it as "cannot be fixed/wont fix". Best, |
@Lorenz1983 to explain where this is coming from. We at ADP prepared translations for Slovenian for DDI Contributor Role, Software Package and Type of Frequency and our translator wanted to put the translations in CVS. She was not able to do this, so I started looking into this. There needs to be a clear workflow explanation for users on how to proceed if they would like to add a new translation to existing CV (the translation in this language does not exist yet). Please get in contact with Sergeja Masten (sergeja.masten@fdv.uni-lj.si) and decide on how to include this translations in the CVS baring in mind the rules you select for the versioning (see my comment on Feb1 around the confusion in the versioning number). |
I am quite certain that the DDI CV people would not be happy that the versioning went one number up, since there was no change in the CV itself (second digit increases as Martin mentioned), translations should be only change in the third digit. But this needs to be discussed and decided. |
@MajaDolinar thank you very much for the information. |
A button to add new translations to CVs is missing. I wanted to add a Slovenian translation to DDI Contributor Role, but I could not.
I checked through my ADMIN-CONTENT role and ADMIN-TL Slovenian role. There is no way to add a new language (eg. Slovenian) to an already published CV. See pictures:
The text was updated successfully, but these errors were encountered: