Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rebar2 #29

Closed
andreineculau opened this issue Jul 9, 2018 · 5 comments
Closed

support rebar2 #29

andreineculau opened this issue Jul 9, 2018 · 5 comments

Comments

@andreineculau
Copy link

In an attempt to upgrade hackney, I have discovered that I cannot use rebar 2 anymore.
The issue is similar to benoitc/hackney#509, just that it is not idna anymore, but certifi as mentioned also in benoitc/hackney#509 (comment) (after the issue has been closed).

Thus a similar fix is needed here for parse_trans as in idna benoitc/erlang-idna@f01533f

@benoitc
Copy link
Contributor

benoitc commented Jul 10, 2018

which error do you have ?

@benoitc benoitc added the bug label Jul 10, 2018
@andreineculau
Copy link
Author

andreineculau commented Jul 10, 2018

Same as in the comment benoitc/hackney#509 (comment)

Dependency not available: parse_trans-3.2.0 (undefined)

@fenollp
Copy link
Contributor

fenollp commented Jul 17, 2018

@andreineculau Is there no way to make you move to rebar3?

@andreineculau
Copy link
Author

It is not just me the individual but all users of hackney (which @benoitc has said in a commit/issue that has to work with rebar2) and all users of my tool https://github.com/for-GET/katt

So all in all, no.
I know it's not a convenient situation, stemming from rebar3's backward-incompat, but if certifi is not to support rebar2, and then hackney neither, then 1. Would be good to state that in clear and 2. That there was a major semver bump when the incompat switch happens/ed

@benoitc
Copy link
Contributor

benoitc commented Aug 3, 2018

it will need another rebar.config.script. i will take care on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants