-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for cloudflare's 3.0 python package #9938
Comments
thanks for the heads up! poking around https://github.com/cloudflare/python-cloudflare and in particular cloudflare/python-cloudflare#191 (comment), it sounds like 2.19.* will receive security fixes for 6 months, after which it will be abandoned. we should try to switch over to 3.0 before then our code supporting both 2.19 and 3.0 may be nice depending on the versions of the cloudflare libraries available in LTS linux distros where the certbot packages are receiving updates. i think ensuring we work with 3.0 is most important though i updated our setup.py file in #9940. i'll leave this issue open to track the 3.0 compatibility work |
The For |
got it. thanks for the additional info ❤️ because of that, 3.0 not being out yet, and us having #9940 which should be merged soon, i'm dropping the priority of this slightly. if someone on the certbot team disagrees with this decision, feel free to bump it back up |
while working on #9938, i updated our dependencies which updated mypy introducing new errors that mypy wanted me to fix. i think this makes the regularly necessary process of updating our dependencies too tedious and we should instead pin our linters that do this to a specific version and update them manually as desired. we already do this with pylint in the lines above my changes in this PR for the same reason
The following ...
... in
certbot-dns-cloudflare
folder needs updating tocloudflare<=2.19.*
. This is explained at github.com/cloudflare/python-cloudflare README file. It's become kinda urgent because of a pending 3.x release that's not code compatible. Certbot will continue to be 100% compatible with the2.19.*
releases.BTW: Upgrading the
cloudflare
requirements from1.5.1
to a newer release is highly recommended as big fixes and major improvements (like keepalive etc) are in the newer releases.The text was updated successfully, but these errors were encountered: