Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matchExpressions to Bundle's spec.target.namespaceSelector #302

Open
sathieu opened this issue Feb 22, 2024 · 3 comments
Open

Add matchExpressions to Bundle's spec.target.namespaceSelector #302

sathieu opened this issue Feb 22, 2024 · 3 comments

Comments

@sathieu
Copy link

sathieu commented Feb 22, 2024

Currently, bundle has:

spec:
  target:
    namespaceSelector:
      matchLabels:
        linkerd.io/inject: "enabled"

We need support for:

spec:
  target:
    namespaceSelector:
      matchExpressions:
      - key: kubitus-project.gitlab.io/inject-ca-bundle
        operator: NotIn
        values:
        - 'false'

Ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#resources-that-support-set-based-requirements

@erikgb
Copy link
Contributor

erikgb commented Feb 22, 2024

I think this was discussed in #258 - as this new feature supports all types of selectors. It would make sense to add this IMO, and I also think it could be added non-breaking. PRs welcome! 😸

@sathieu
Copy link
Author

sathieu commented Feb 22, 2024

@ocampeau Could you please take a look at this feature request 🙏?

@ocampeau
Copy link
Contributor

I think it could be a nice addition yes. This can definitely be done in a non-breaking fashion. The Kubernetes libraries already provides the types for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants