Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 upgrade #161

Closed
1 of 4 tasks
bjankord opened this issue Jul 24, 2017 · 7 comments
Closed
1 of 4 tasks

React 16 upgrade #161

bjankord opened this issue Jul 24, 2017 · 7 comments
Assignees
Milestone

Comments

@bjankord
Copy link
Contributor

Issue Description

When react 16 comes out, we'll want to enable compatibility with react 16.

Issue Type

  • New Feature
  • Enhancement
  • Bug
  • Other

Expected Behavior

Terra components are compatible with React 16

Current Behavior

N/A

@bjankord bjankord added this to the Q3 milestone Jul 24, 2017
@noahbenham
Copy link
Contributor

noahbenham commented Aug 22, 2017

Will any uplifts you perform be backwards compatible to consumers using React 15? We still have substantial work to do uplifting deprecated code.

@emilyrohrbough
Copy link
Contributor

@noahbenham uplifts to use React 16 should remain compatible with React 15 as well.

@emilyrohrbough
Copy link
Contributor

The React Team's progress in releasing v16 facebook/react#10294

@emilyrohrbough
Copy link
Contributor

emilyrohrbough commented Sep 27, 2017

Third Party Dependencies Requiring React:

Good To Go Dependency Current Specified Version React 16 Supported Version Watch Issue
BLOCKED enzyme v^2.8.2 v^3.x #198
react-intl v^2.2.3 & v^2.3.0 v2.4.0 Need to bump to v2.4.0
react-redux v^5.0.4 v4.4.7 N/A
react-router v^3.0.5 v3.2.0 Need to bump to v3.2.0
react-modal v^1.6.5 v3.0 Bump to v4 minimum....Closed: reactjs/react-modal#498
react-router-dom v^4.0.0 v4.0.2 Bump to 4.0.2....Closed: remix-run/react-router#5563

@emilyrohrbough
Copy link
Contributor

This is blocked by:

@emilyrohrbough emilyrohrbough modified the milestones: Q3, Q4 2017 Sep 27, 2017
@emilyrohrbough
Copy link
Contributor

Upon checking the react-modal commit history, React 16 compatibility is available in v3.0, however, I noticed a message indicated v4.0.0-beta.5 replaced PropTypes with the prop-types library. To ensure not warnings occur, we should bump to a minimum of v4.0.0.

@emilyrohrbough
Copy link
Contributor

Unblocked by #198. However will need to implement enzyme-adapter-react-16.

@alecrowen alecrowen modified the milestones: Q4 2017, Q1 2018 Dec 7, 2017
@benbcai benbcai added this to In Progress in Terra Feb 12, 2018
@benbcai benbcai self-assigned this Feb 12, 2018
@benbcai benbcai moved this from In Progress to In Review in Terra Feb 14, 2018
@emilyrohrbough emilyrohrbough moved this from In Review to Ready for Release in Terra Feb 19, 2018
@bjankord bjankord removed this from Ready for Release in Terra Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants