Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose as ESM #24

Merged
merged 4 commits into from Apr 8, 2022
Merged

Conversation

ukstv
Copy link
Contributor

@ukstv ukstv commented Apr 8, 2022

Move the package to be ESM and ES2020 only.

@rvagg any concerns?

@linear
Copy link

linear bot commented Apr 8, 2022

@ukstv ukstv requested a review from oed April 8, 2022 15:02
Copy link
Member

@oed oed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -11,7 +11,7 @@ jobs:
- name: Use Node 12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Use Node 12
- name: Use Node 16

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe test with both 14 and 16?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@ukstv ukstv merged commit e53fbda into main Apr 8, 2022
@ukstv ukstv deleted the feature/net-1401-translate-js-dag-jose-to-esm branch April 8, 2022 19:18
@rvagg
Copy link
Contributor

rvagg commented Apr 20, 2022

sorry! late to the party, but +1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants