rebase: bump sigs.k8s.io/controller-runtime from 0.17.3 to 0.18.0 in the k8s-dependencies group #4595
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the k8s-dependencies group with 1 update: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime). Updates `sigs.k8s.io/controller-runtime` from 0.17.3 to 0.18.0 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.17.3...v0.18.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
nixpanic
force-pushed
the
dependabot/go_modules/k8s-dependencies-05f7cb983f
branch
from
298f73a
to
81044ed
Compare
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
controller-runtime changed the format of the controller.Watch() function, so that needs adjusting. See-also: kubernetes-sigs/controller-runtime#2783 Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic
force-pushed
the
dependabot/go_modules/k8s-dependencies-05f7cb983f
branch
from
81044ed
to
1b7437d
Compare
go.mod
Outdated
| go 1.22 | ||
|
|
||
| toolchain go1.22.2 |
There was a problem hiding this comment.
$]cat go.mod |grep -i "1.22"
go 1.22
toolchain go1.22.2
code.cloudfoundry.org/gofileutils => github.com/cloudfoundry/gofileutils v0.0.0-20170111115228-4d0c80011a0f
[🎩︎]mrajanna@li-2cfbef4c-22d9-11b2-a85c-a3e4a93c405f ceph-csi $]go mod tidy
[🎩︎]mrajanna@li-2cfbef4c-22d9-11b2-a85c-a3e4a93c405f ceph-csi $]git diff
diff --git a/go.mod b/go.mod
index 076fc38c7..92ce83ca3 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,7 @@
module github.com/ceph/ceph-csi
-go 1.22
+go 1.22.0
+
toolchain go1.22.2
require (
[🎩︎]mrajannaceph-csi $]go version
go version go1.22.2 linux/amd64@nixpanic when i ran go mod tidy above is getting reverted back.
There was a problem hiding this comment.
Strange, what do you recommend then?
Have the minor version included, as it might get added by some commands again anyway?
go 1.22.0
toolchain go1.22.2
There was a problem hiding this comment.
we can have both or drop toolchain, if we are going with both lets keep the version same in both (which is nothing both dropping toolchain internally)
There was a problem hiding this comment.
Now without toolchain. I guess go mod tidy added that at one point. Maybe it is not required anymore?
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic
force-pushed
the
dependabot/go_modules/k8s-dependencies-05f7cb983f
branch
from
aa8be9b
to
886f5dd
Compare
mergify
bot
dismissed stale reviews from iPraveenParihar and nixpanic
Pull request has been modified.
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
Several e2e failures: CephFS: RBD: |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
Looks like sigs.k8s.io/controller-runtime is updatable in another way, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/go_modules/k8s-dependencies-05f7cb983f
branch
Bumps the k8s-dependencies group with 1 update: sigs.k8s.io/controller-runtime.
Updates
sigs.k8s.io/controller-runtimefrom 0.17.3 to 0.18.0Release notes
Sourced from sigs.k8s.io/controller-runtime's releases.
... (truncated)
Commits
ed81fa6Merge pull request #2796 from alvaroaleman/markb35cd6b📖 Mark Typed Handlers as experimentalb74908fMerge pull request #2793 from kubernetes-sigs/dependabot/github_actions/actio...a9db208Merge pull request #2794 from kubernetes-sigs/dependabot/github_actions/actio...757ae66🌱 Bump actions/upload-artifact from 4.3.1 to 4.3.318ae9e0🌱 Bump actions/checkout from 4.1.2 to 4.1.34f00207Merge pull request #2792 from sbueringer/pr-fix-typo9fb4913Fix typo in channel option5823d1bMerge pull request #2791 from alvaroaleman/add-default-transformae0f6abMerge pull request #2783 from alvaroaleman/compatible-genericsYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions