Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencensus-ext-django: upgrade pre-Django 1.10-style middleware #1161

Open
JeremyVriens opened this issue Aug 26, 2022 · 1 comment
Open
Assignees

Comments

@JeremyVriens
Copy link
Contributor

Background
Currently the opencensus-ext-django package has a version pin on django>=1.11, but it still uses the pre-Django 1.10-style middleware.
Since the current base class of the middleware is deprecated (assuming by the fact that it's loaded from the django.utils.deprecation package), the deprecated class can be removed at any point in time in the future.

Proposed solution
The middleware class should be refactored to the "new way of writing middlewares" as described in the Django documentation.

Acceptance criteria
No breaking changes. The refactor should be fully backwards compatible with the current middleware class.

@JeremyVriens
Copy link
Contributor Author

I created this feature request/issue based on the findings after fixing #1154 and I will pick this one up myself as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant