Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Fix CI, and update testify #1284

Merged
merged 2 commits into from Nov 3, 2022
Merged

Conversation

dashpole
Copy link
Collaborator

@dashpole dashpole commented Nov 1, 2022

Address #1283 (comment)

Also, update testify, and run go fmt.

Fixes #1282

@punya
Copy link
Contributor

punya commented Nov 1, 2022

The changes in this PR seem safe, but are we concerned that this might make it easy for us to break pre-1.18 users in future PRs?

@dashpole
Copy link
Collaborator Author

dashpole commented Nov 1, 2022

The changes in this PR seem safe, but are we concerned that this might make it easy for us to break pre-1.18 users in future PRs?

We don't currently test multiple versions, so we might be breaking any version other than the one we are testing. 1.18 seemed reasonable, since it is 1 behind the latest go release.

punya
punya previously approved these changes Nov 2, 2022
@punya punya dismissed their stale review November 2, 2022 21:03

Approved by accident.

@punya
Copy link
Contributor

punya commented Nov 2, 2022

OpenCensus is meant to be in maintenance mode, so I would expect the minimum required versions of its dependencies to remain unchanged unless there's a high priority bugfix or security vulnerability. This should apply to the Go version as well.

I would support

  • updating the documentation to handle recent versions of Go correct (go install vs go get)
  • narrowly updating the testify dependency to fix the problem

I would want OpenCensus-Go to keep building and testing against an old version of Go, and relying on the backwards compatibility of the Go language and stdlib for newer versions.

Happy to discuss in person if I'm misunderstanding the purpose of this PR.

@dashpole
Copy link
Collaborator Author

dashpole commented Nov 2, 2022

@punya
done

@dashpole dashpole changed the title Update go and dependencies Fix CI, and update testify Nov 2, 2022
@dashpole dashpole merged commit 0bf7faa into census-instrumentation:master Nov 3, 2022
@dashpole dashpole deleted the fix_ci branch November 3, 2022 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testify needs updating due to DOS and Null ptr dereference - plz update testify to >= 1.7.5
2 participants