Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

CMake followups #244

Open
3 of 16 tasks
g-easy opened this issue Nov 29, 2018 · 5 comments
Open
3 of 16 tasks

CMake followups #244

g-easy opened this issue Nov 29, 2018 · 5 comments

Comments

@g-easy
Copy link
Contributor

g-easy commented Nov 29, 2018

Experimental CMake support was added in PR #238 to address issue #86. This issue is to track followup work from the PR:

@meastp
Copy link
Contributor

meastp commented Feb 25, 2019

While working on various changes (#284 and #283), I experimented with replacing the current ExternalProject with FetchContent. This works very well and reduces the amount of code substantially.

Are you interested in a PR with this (that is, replace ExternalProject with FetchContent? Since you have Bazel, requiring CMake >= 3.11 might be okay? :) (CMake 3.14 also got the super-simple function FetchContent_MakeAvailable which automatically handles dependency chains as well)

Then (because the amount of code is reduced) it will also be easier to implement an option to switch between FetchContent and find_package...

@meastp
Copy link
Contributor

meastp commented Feb 26, 2019

I built all components with Debug (x64) and ran all 189 tests successfully on MSVC 2017 v15.9.7. 👍

I also built with RelWithDebugInfo (x64) - that only discovered 186 tests, and of the 186 tests, these 6 tests failed:

[26.02.2019 19.51.33 Informational] [ FAILED ] 6 tests, listed below:
[26.02.2019 19.51.33 Informational] [ FAILED ] StatsObjectTest.BucketBoundary
[26.02.2019 19.51.33 Informational] [ FAILED ] StatsObjectTest.GetStatsFuture
[26.02.2019 19.51.33 Informational] [ FAILED ] StatsObjectTest.IncompleteFirstBucket
[26.02.2019 19.51.33 Informational] [ FAILED ] StatsObjectTest.Shift
[26.02.2019 19.51.33 Informational] [ FAILED ] StatsObjectTest.MergeIncompleteFirstBucket
[26.02.2019 19.51.33 Informational] [ FAILED ] StatsObjectTest.SteadyStateDistribution

@g-easy
Copy link
Contributor Author

g-easy commented Feb 27, 2019

I'm happy to replace ExternalProject with FetchContent. If you could please send a PR for this, that would be great.

If v3.11 becomes a problem for people, we can (later) try to import the FetchContent implementation like #256 (comment) says.

n.b. Our Travis config specifies Trusty which ships with CMake 3.9.2, so maybe switch (only) the CMake build to Xenial for now.

@meastp
Copy link
Contributor

meastp commented Mar 14, 2019

See #296 for benchmark support

@Dlougach
Copy link

Dlougach commented Jun 1, 2020

I am interested to use opencensus in one of my projects, but I would need the following:

Add find_package / install support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants