We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is()
While looking through the code I noticed this:
backoff/retry.go
Lines 99 to 102 in a78d380
Go doesn't support (yet) the Is(err) function for use in errors.Is(), and if it did then this implementation is fast but wrong for all wrapped errors.
Is(err)
errors.Is()
Can we remove this? I think it's confusing and might break in the future
The text was updated successfully, but these errors were encountered:
@Hades32, can you clarify the "wrong for all wrapped errors" part? The current implementation of the errors.Is function will progress beyond an error's Is method that doesn't match the target error and inspect the wrapped errors revealed by an error's Unwrap method.
errors.Is
Is
Unwrap
Sorry, something went wrong.
No branches or pull requests
While looking through the code I noticed this:
backoff/retry.go
Lines 99 to 102 in a78d380
Go doesn't support (yet) the
Is(err)
function for use inerrors.Is()
, and if it did then this implementation is fast but wrong for all wrapped errors.Can we remove this? I think it's confusing and might break in the future
The text was updated successfully, but these errors were encountered: