Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure no randomness is used when randomizationFactor is 0 #118

Merged
merged 1 commit into from Nov 11, 2021

Conversation

nirrozenbaum
Copy link
Contributor

in current implementation there is the following issue - it's not possible to disable randomization.
I'd expect that if I set randomizationFactor to 0, no randomness will be done.

I've updated the code accordingly to fix the issue.

in current implementation there is the following issue - it's not possible to disable randomization.
I'd expect that if I set randomizationFactor to 0, no randomness will be done.

I've updated the code accordingly to fix the issue.
@nirrozenbaum
Copy link
Contributor Author

nirrozenbaum commented Nov 11, 2021

@cenkalti hi,
I've created a PR to fix randomization issue I found.. it's not possible to disable randomization with current solution.
even if randomizationFactor is set to zero, it will be incremented by a random value between [0.0, 1.0).
(because of the +1 in the getRandomValueFromInterval function).
I've addressed the issue in this PR.
would appreciate your review.
thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants