Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FeeCurrencyDirectory to Anvil migrations #10991

Closed
Tracked by #10990
arthurgousset opened this issue May 13, 2024 · 2 comments · Fixed by #10992
Closed
Tracked by #10990

Add FeeCurrencyDirectory to Anvil migrations #10991

arthurgousset opened this issue May 13, 2024 · 2 comments · Fixed by #10992
Assignees

Comments

@arthurgousset
Copy link
Member

arthurgousset commented May 13, 2024

Description

@pahor167 merged the Anvil integration and FeeCurrencyDirectory PRs:

As a follow-up task, it would be good to add the FeeCurrencyDirectory to our Anvil migrations.

Context

Slack thread

@arthurgousset
Copy link
Member Author

Estimates:

  • Days - best: 1
  • Days - most likely: 3
  • Days - worst: 4

Assumptions for my estimates:

  • I'm working on this during the DevTooling offsite in Warsaw. I don't expect to have long, uninterrupted periods of focus time.
  • Even though I was in the Anvil meeting with Pavel/Volpe, I don't (really) understand how the shell scripts (e.g. migrations_sol/create_and_migrate_anvil_devchain.sh) and "fake" solidity files (e.g. migrations_sol/Migration.s.sol) work together to instantiate an anvil fork with the Celo core contracts. I think a good first step is to better understand how these files work together to create a working devchain. I'll measure my progress by the ability to (generate) and run a devchain locally, without starting from the JSON dump. I can probably work most of this out by looking at Github workflow that orchestrates all this.

@arthurgousset
Copy link
Member Author

Working on this branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant